<html>
<head><meta charset="utf-8"><title>How to unclose the tree? · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html">How to unclose the tree?</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="218930900"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218930900" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218930900">(Dec 05 2020 at 11:22)</a>:</h4>
<p><code>@bors treeclosed-</code> <a href="https://github.com/rust-lang/rust/pull/76301#issuecomment-739237719">does not seem to do anything</a></p>



<a name="218930974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218930974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218930974">(Dec 05 2020 at 11:25)</a>:</h4>
<p>ah, seems I had to do the command in a different PR. That's weird, is this a bug?</p>



<a name="218930980"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218930980" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218930980">(Dec 05 2020 at 11:25)</a>:</h4>
<p>it would be good if the bot at least would let us know that it just ignored our commands^^</p>



<a name="218949163"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218949163" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218949163">(Dec 05 2020 at 19:25)</a>:</h4>
<p><span class="user-mention silent" data-user-id="120791">RalfJ</span> <a href="#narrow/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F/near/218930974">said</a>:</p>
<blockquote>
<p>ah, seems I had to do the command in a different PR. That's weird, is this a bug?</p>
</blockquote>
<p>Hmm, is that really only what fixed it? Looking through the homu source code, I don't see anything that might cause that.</p>



<a name="218949386"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218949386" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218949386">(Dec 05 2020 at 19:30)</a>:</h4>
<p>Though if I understand this code correctly, it seems to be deleting the entire row in the <code>repos</code> table?!</p>
<div class="codehilite" data-code-language="Python"><pre><span></span><code>    <span class="k">def</span> <span class="nf">update_treeclosed</span><span class="p">(</span><span class="bp">self</span><span class="p">,</span> <span class="n">value</span><span class="p">,</span> <span class="n">src</span><span class="p">):</span>
        <span class="bp">self</span><span class="o">.</span><span class="n">treeclosed</span> <span class="o">=</span> <span class="n">value</span>
        <span class="bp">self</span><span class="o">.</span><span class="n">treeclosed_src</span> <span class="o">=</span> <span class="n">src</span>
        <span class="n">db_query</span><span class="p">(</span>
            <span class="bp">self</span><span class="o">.</span><span class="n">db</span><span class="p">,</span>
            <span class="s1">'DELETE FROM repos where repo = ?'</span><span class="p">,</span>
            <span class="p">[</span><span class="bp">self</span><span class="o">.</span><span class="n">repo_label</span><span class="p">]</span>
        <span class="p">)</span>
        <span class="k">if</span> <span class="n">value</span> <span class="o">&gt;</span> <span class="mi">0</span><span class="p">:</span>
            <span class="n">db_query</span><span class="p">(</span>
                <span class="bp">self</span><span class="o">.</span><span class="n">db</span><span class="p">,</span>
                <span class="sd">'''</span>
<span class="sd">                    INSERT INTO repos (repo, treeclosed, treeclosed_src)</span>
<span class="sd">                    VALUES (?, ?, ?)</span>
<span class="sd">                '''</span><span class="p">,</span>
                <span class="p">[</span><span class="bp">self</span><span class="o">.</span><span class="n">repo_label</span><span class="p">,</span> <span class="n">value</span><span class="p">,</span> <span class="n">src</span><span class="p">]</span>
            <span class="p">)</span>
</code></pre></div>



<a name="218949627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218949627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218949627">(Dec 05 2020 at 19:35)</a>:</h4>
<p>Opened <a href="https://github.com/rust-lang/homu/issues/128">rust-lang/homu#128</a> for the deleting of the row. Not sure if it's related to the problem you were having though.</p>



<a name="218950428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218950428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218950428">(Dec 05 2020 at 19:53)</a>:</h4>
<p>We don't currently accept commands on closed/merged PRs</p>



<a name="218950548"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218950548" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218950548">(Dec 05 2020 at 19:56)</a>:</h4>
<p>Ah! That makes sense. <span class="user-mention" data-user-id="120791">@RalfJ</span> ^</p>



<a name="218980293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/How%20to%20unclose%20the%20tree%3F/near/218980293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F.html#218980293">(Dec 06 2020 at 10:30)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/242791-t-infra/topic/How.20to.20unclose.20the.20tree.3F/near/218950428">said</a>:</p>
<blockquote>
<p>We don't currently accept commands on closed/merged PRs</p>
</blockquote>
<p>yeah that's what I figured. just silently ignoring them is confusing though.^^</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>